Skip to content

bump go version to fix multiple CVEs #1842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

bump go version to fix multiple CVEs #1842

wants to merge 1 commit into from
+1 −1

Conversation

@ErickRDS
Copy link
Contributor

@ErickRDS ErickRDS commented Nov 21, 2025

Description of the change:
Update the go directive in go.mod from 1.24.6 to 1.24.10 to solve multiple issues described in #1841.

Motivation for the change:
Internal security scanners flagged this repository for multiple CVEs. The Go team fixed this issue in Go 1.24.8 (and 1.25.2). Bumping to 1.24.10 ensures compliance and mitigates the vulnerability, closing #1841.
I’m bumping Go to 1.24.10 instead of 1.24.8 because 1.24.10 is the latest patch release in the 1.24 line, so it includes all fixes from 1.24.8 plus additional bug and security fixes while staying within the same minor version. If you would prefer to update directly to Go 1.25.2, please let me know and I can adjust this PR to target that version instead.

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 21, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign perdasilva for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 21, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 21, 2025

Hi @ErickRDS. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@codecov
Copy link

codecov bot commented Nov 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.50%. Comparing base (e7b9dee) to head (5496573).

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1842      +/-   ##
==========================================
- Coverage   57.52%   57.50%   -0.02%     
==========================================
  Files         136      136              
  Lines       12934    12934              
==========================================
- Hits         7440     7438       -2     
- Misses       4339     4341       +2     
  Partials     1155     1155

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@everettraven everettraven Awaiting requested review from everettraven

@grokspawn grokspawn Awaiting requested review from grokspawn

Assignees

No one assigned

Labels

needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ErickRDS